kubereboot
Propagate Context
Propagate a context from the main function to wherever it is needed.
Use github.com/oklog/run run groups to handle the life cycle of the go
routines running the rebooter and metrics server.
Ref: https://github.com/kubereboot/kured/issues/234 and https://github.com/kubereboot/kured/pull/808
Signed-off-by: leonnicolas [email protected]
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days).
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Would you mind explaining why it mattered for you?
Passing down a context makes sure that when a caller wants to cancel an operation, some function down the line will not block until it returns. Instead it would probably return a context canceled. In practice, when kured received a SIGINT, it can cancel all outgoing requests and finish processing all incoming requests to the metrics server before it exits.
And why did you want to use background context, please?
This is normally the context you use in the "root" of the application. https://pkg.go.dev/context#Background
And why you used oklog?
At the moment kured starts 2 concurrent processes (go threads) in its main function and the metrics server that blocks the main thread forever. If any of the go threads crash, we would continue to run the metrics server. No way to tell the other thread to exit as well and terminate the main thread (or try to restart the crashed thread). oklog's run package just provides one way to manage the life cycle of threads. We could probably use other packages as well. It was just my personal favorite because its API is so slim.
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days).
Now that you commented on this PR, I think everyone can follow your train of thoughts in the future. I am fine with merging this.
The slight issue I have right now, is my lack of lab to test this. Can anyone test this and see the impact on stuff like the prom' integration? If it still works for someone, I am okay to go forward.
This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days).