guard icon indicating copy to clipboard operation
guard copied to clipboard

Use retryable http client in Azure authz provider

Open bingosummer opened this issue 1 year ago • 4 comments

We see the timeout error in the checkaccess requrests sometimes.

Error occured during authorization check. Please retry again. Error: Checkaccess requests have timed out.: context deadline exceeded

This PR moves withRetryableHttpClient from Azure authn provider to utils, and leverage it in Azure authz provider's RefreshToken and CheckAccess.

bingosummer avatar Aug 07 '23 06:08 bingosummer

@weinong @AzureMarker could you please have a review? Thanks!

bingosummer avatar Aug 07 '23 07:08 bingosummer

@AzureMarker Could you please have a review again? Thanks

bingosummer avatar Nov 21 '23 08:11 bingosummer

@weinong could you please have a review? Thanks

bingosummer avatar Jan 18 '24 05:01 bingosummer

The PR is rebased. @weinong could you please have a review? Please let me know if anything is missing. Thanks!

bingosummer avatar Mar 07 '24 02:03 bingosummer

@weinong could you please have another round of review? Thanks

bingosummer avatar Apr 02 '24 02:04 bingosummer

@julienstroheker PTAL

weinong avatar Apr 02 '24 03:04 weinong