xgboost-operator icon indicating copy to clipboard operation
xgboost-operator copied to clipboard

presubmit build have one extra argument

Open Jeffwan opened this issue 5 years ago • 1 comments

/bin/bash -c /mnt/test-data-volume/kubeflow-xgboost-operator-presubmit-build-70-9aa764f-7905-1ef1/src/kubeflow/xgboost-operator//build_image.sh 

/mnt/test-data-volume/kubeflow-xgboost-operator-presubmit-build-70-9aa764f-7905-1ef1/src/kubeflow/xgboost-operator/Dockerfile 
gcr.io/kubeflow-ci/xgboost-operator 
v1.0

In build_image.sh scripts, we only consume two arguments. https://github.com/kubeflow/xgboost-operator/blob/78f8cf50bb943247e038a8feb5a9f7e47d810d65/build_image.sh#L10-L12

If we add extra argument, it will v1.0 will be assigned which may brings problems. I meet this problem working on https://github.com/kubeflow/xgboost-operator/pull/70

At the beginning, I use TIMEOUT=${3-:30m} then it grants v1.0 to timeout and fail the test.

I think we can either delete v1.0 tag, since build_image.sh generate dirty tags here

https://github.com/kubeflow/xgboost-operator/blob/78f8cf50bb943247e038a8feb5a9f7e47d810d65/build_image.sh#L16

Jeffwan avatar May 14 '20 00:05 Jeffwan

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.91

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar May 14 '20 00:05 issue-label-bot[bot]