trainer: User guide for PyTorch Training
Checklist:
- [x] You have signed off your commits
- [x] Ensure you follow best practices from our guide. Contributing.
- [ ] You have included screenshots when changing the website style or adding a new page.
Description of your changes: User guide for PyTorch Training
Issue
Closes: kubeflow/trainer#2543
Labels
/area trainer
Hi @izuku-sds. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
PTAL @andreyvelich Thankyou.
@andreyvelich is this good to merge ?
@andreyvelich is this good to merge ?
Not yet, @izuku-sds maybe in PyTorch guide we can reduce content for the training function to add high-level items (e.g. define dataset, model, and training loop). We should also explain that Kubeflow Trainer automatically sets the correct environment for the PyTorch Distributed: https://docs.pytorch.org/tutorials/beginner/dist_overview.html E.g. WORLD_SIZE, RANK, and LOCAL_RANK is available inside the training function.
cc @kramaranya @szaher @eoinfennessy
@kramaranya @astefanutti Thanks for the review! Please let me know if we should update any other docs before we can merge this initial changes to the PyTorch guide.
@Electronic-Waste @eoinfennessy @kramaranya @astefanutti Any other suggestions to the PR before we move forward?
@andreyvelich Just one concern: #4053 (comment). But it should not block this PR:)
/lgtm
Sure, I will create the tracking issue in Kubeflow SDK
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andreyvelich
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~content/en/docs/components/trainer/OWNERS~~ [andreyvelich]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment