website icon indicating copy to clipboard operation
website copied to clipboard

model-registry: add YAML manifest example for creating InferenceService

Open milinddethe15 opened this issue 11 months ago • 2 comments

Checklist:

  • [x] You have signed off your commits
  • [x] Ensure you follow best practices from our guide. Contributing.
  • [] You have included screenshots when changing the website style or adding a new page.

Description of your changes: Preview the changes here: https://deploy-preview-4048--competent-brattain-de2d6d.netlify.app/docs/components/model-registry/getting-started/#using-model-registry-custom-storage-initializer

Issue

Closes: https://github.com/kubeflow/model-registry/issues/801

Labels

/area model-registry


milinddethe15 avatar Mar 16 '25 18:03 milinddethe15

Hi @milinddethe15. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Mar 16 '25 18:03 google-oss-prow[bot]

/assign @Al-Pragliola for your 👀 as well, please?

tarilabs avatar May 06 '25 17:05 tarilabs

The yaml looks good to me, what about adding a few words about using the file with kubectl apply? Just because we were in the context of a Jupyter notebook in this section of the guide

Al-Pragliola avatar May 06 '25 17:05 Al-Pragliola

The yaml looks good to me, what about adding a few words about using the file with kubectl apply? Just because we were in the context of a Jupyter notebook in this section of the guide

fair, would you agree in a separate, follow-up PR @Al-Pragliola ?

tarilabs avatar May 06 '25 19:05 tarilabs

The yaml looks good to me, what about adding a few words about using the file with kubectl apply? Just because we were in the context of a Jupyter notebook in this section of the guide

fair, would you agree in a separate, follow-up PR @Al-Pragliola ?

Fine by me! 😄

Al-Pragliola avatar May 06 '25 19:05 Al-Pragliola

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 06 '25 19:05 google-oss-prow[bot]

@milinddethe15 if you are experimenting/adopting Kubeflow Model Registry in your company, we invite you to consider adding an entry to the KF MR Adopters file: https://github.com/kubeflow/model-registry/blob/main/ADOPTERS.md

tarilabs avatar May 06 '25 20:05 tarilabs