website icon indicating copy to clipboard operation
website copied to clipboard

docs(trainer): introduce trainer pipeline framework for new users in kubeflow trainer v2

Open IRONICBo opened this issue 9 months ago • 3 comments

Checklist:

  • [x] You have signed off your commits
  • [x] Ensure you follow best practices from our guide. Contributing.
  • [] You have included screenshots when changing the website style or adding a new page.

Description of your changes:

Introduce trainer v2 TrainerPepelineFramework in website, reference design doc is in TrainerPipelineFramework.

Issue

Closes: #https://github.com/kubeflow/trainer/issues/2458

Labels

/area trainer /area website

IRONICBo avatar Mar 11 '25 15:03 IRONICBo

Hi @IRONICBo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Mar 11 '25 15:03 google-oss-prow[bot]

The Issue already mentions the need to introduce documentation similar to the TrainerPipelineFramework in issue, which I've done a simple fine-tuning of, but I'm not sure if there are any other suggestions that need to be confirmed or discussed, so let me know if there are any, and I'll follow up in a timely manner.

IRONICBo avatar Mar 11 '25 15:03 IRONICBo

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 10 '25 00:06 github-actions[bot]

/remove-lifecycle stale /assign @tenzen-y @Electronic-Waste

andreyvelich avatar Jun 10 '25 01:06 andreyvelich

Hi @IRONICBo, did you get a chance to address the remaining comments ? Having this documentation would be super helpful to understand the KF Trainer architecture.

andreyvelich avatar Sep 11 '25 13:09 andreyvelich

Hi @IRONICBo, did you get a chance to address the remaining comments ? Having this documentation would be super helpful to understand the KF Trainer architecture.

@andreyvelich Sorry for this late reply, I have replied to all changes in this doc :)

IRONICBo avatar Sep 15 '25 16:09 IRONICBo

/lgtm

Thanks @IRONICBo!

astefanutti avatar Sep 22 '25 12:09 astefanutti

Thanks for this great contribution @IRONICBo! /lgtm /approve

andreyvelich avatar Sep 22 '25 16:09 andreyvelich

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Sep 22 '25 16:09 google-oss-prow[bot]