website icon indicating copy to clipboard operation
website copied to clipboard

Fix grammar in "Quirks of the process" section on the Contributing page

Open RehanFazal77 opened this issue 9 months ago • 5 comments

Checklist:

  • [x] You have signed off your commits
  • [x] Ensure you follow best practices from our guide. Contributing.
  • [x] You have included screenshots when changing the website style or adding a new page.

Description of your changes: This pull request makes two grammatical corrections in the “Quirks of the process” section of the Contributing page to improve clarity and readability:

Comma Placement: Before: “There are a number of behaviors we’ve observed that while possible are discouraged…” After: “There are a number of behaviors we’ve observed that, while possible, are discouraged…” Explanation: Adding commas around “while possible” correctly sets off the clause, clarifying the sentence structure.

Phrasing Update: Before: “…but this is the state of today.” After: “…but this is the state of things today.” Explanation: Changing the phrasing to “state of things today” makes the sentence more natural and clear.


Screenshot from 2025-03-08 18-40-30

RehanFazal77 avatar Mar 08 '25 13:03 RehanFazal77

Hi @RehanFazal77. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Mar 08 '25 13:03 google-oss-prow[bot]

/hold

varodrig avatar Mar 11 '25 01:03 varodrig

@RehanFazal77 Please sign off your commits following; the PR will not be merged/approved until all the checks have passed. https://github.com/kubeflow/website/pull/4035/checks?check_run_id=38423945244

varodrig avatar Mar 11 '25 01:03 varodrig

@varodrig, I've updated my commits and added the required sign-offs. Please let me know if there's anything else needed. Thanks, Rehan

RehanFazal77 avatar Mar 11 '25 06:03 RehanFazal77

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 10 '25 00:06 github-actions[bot]

/lgtm /approve

juliusvonkohout avatar Jun 17 '25 13:06 juliusvonkohout

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jun 17 '25 13:06 google-oss-prow[bot]