update to the new image with the correct links
https://github.com/kubeflow/trainer/issues/2499
Hi @itaynvn-runai. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@terrytangyuan: GitHub didn't allow me to request PR reviews from the following users: to, double, check.
Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
LGTM
/cc @johnugeorge @andreyvelich to double check
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/cc @johnugeorge @andreyvelich
@andreyvelich should we use the latest image on this example?
@andreyvelich should we use the latest image on this example?
@andreyvelich @johnugeorge to approve PR and add any comments if needed.thank you
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically closed because it has not had recent activity.You can reopen the PR if you want.
Sorry for the late reply @itay-nvn-nv and thanks for the fix! /lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andreyvelich
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [andreyvelich]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andreyvelich
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [andreyvelich]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@itay-nvn-nv You might need to rebase your PR to merge it.
@itay-nvn-nv can you rebase? Thanks so much for the work here!
The page seems to have moved /close
please reopen if necessary.
@juliusvonkohout: Closed this PR.
In response to this:
The page seems to have moved /close
please reopen if necessary.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.