website icon indicating copy to clipboard operation
website copied to clipboard

update to the new image with the correct links

Open itay-nvn-nv opened this issue 1 year ago • 6 comments

https://github.com/kubeflow/trainer/issues/2499

itay-nvn-nv avatar Dec 10 '24 07:12 itay-nvn-nv

Hi @itaynvn-runai. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Dec 10 '24 08:12 google-oss-prow[bot]

@terrytangyuan: GitHub didn't allow me to request PR reviews from the following users: to, double, check.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

LGTM

/cc @johnugeorge @andreyvelich to double check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Dec 12 '24 03:12 google-oss-prow[bot]

/cc @johnugeorge @andreyvelich

terrytangyuan avatar Dec 12 '24 03:12 terrytangyuan

@andreyvelich should we use the latest image on this example?

varodrig avatar Jan 19 '25 00:01 varodrig

@andreyvelich should we use the latest image on this example?

@andreyvelich @johnugeorge to approve PR and add any comments if needed.thank you

varodrig avatar Feb 14 '25 03:02 varodrig

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 16 '25 00:05 github-actions[bot]

This pull request has been automatically closed because it has not had recent activity.You can reopen the PR if you want.

github-actions[bot] avatar Jun 07 '25 00:06 github-actions[bot]

Sorry for the late reply @itay-nvn-nv and thanks for the fix! /lgtm /approve

andreyvelich avatar Jun 07 '25 00:06 andreyvelich

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jun 07 '25 00:06 google-oss-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jun 07 '25 00:06 google-oss-prow[bot]

@itay-nvn-nv You might need to rebase your PR to merge it.

andreyvelich avatar Jun 07 '25 00:06 andreyvelich

@itay-nvn-nv can you rebase? Thanks so much for the work here!

franciscojavierarceo avatar Jun 17 '25 13:06 franciscojavierarceo

The page seems to have moved /close

please reopen if necessary.

juliusvonkohout avatar Jun 17 '25 13:06 juliusvonkohout

@juliusvonkohout: Closed this PR.

In response to this:

The page seems to have moved /close

please reopen if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Jun 17 '25 13:06 google-oss-prow[bot]