website icon indicating copy to clipboard operation
website copied to clipboard

model registry: update MLOps diagrams

Open tarilabs opened this issue 1 year ago • 6 comments

Based on previous feedback from:

  • https://github.com/kubeflow/website/pull/3698#issuecomment-2069810560
  • https://github.com/kubeflow/website/pull/3698#discussion_r1597274742

Reorganize diagrams as follows:

  1. make MLOps inner Vs outer cycle smaller just to introduce the concept
  2. re-use overall architecture diagram for Kubeflow introduced with https://github.com/kubeflow/website/pull/3728 2.a. use similar style from https://www.kubeflow.org/docs/components/training/overview/#why-training-operator- and adapt to highlight the Model Registry box

Quick demo: Screenshot 2024-07-26 at 10 44 24

This actualize the agreement from:

  • https://github.com/kubeflow/website/pull/3698#discussion_r1607299980

@StefanoFioravanzo @andreyvelich wdyt ?

tarilabs avatar Jul 26 '24 08:07 tarilabs

I liked the diagram @tarilabs ! /lgtm

ederign avatar Jul 26 '24 12:07 ederign

/hold for review

tarilabs avatar Jul 26 '24 12:07 tarilabs

@tarilabs Nice diagram! All the components that "push" metadata to the model registry can also "pull" from it. How can we better represent this symmetry? Directional rows may give a wrong representation

StefanoFioravanzo avatar Jul 29 '24 06:07 StefanoFioravanzo

@tarilabs Nice diagram! All the components that "push" metadata to the model registry can also "pull" from it. How can we better represent this symmetry? Directional rows may give a wrong representation

thanks! I'm starting to followup on received feedback which I didn't have bandwidth to act upon before.

It is a valid comment, even tho I'd say for the most past some components mainly push and occasionally pull (or viceversa) but I concur a bidirectional symmetric arrow might just be good enough, will do 👍

tarilabs avatar Jul 29 '24 08:07 tarilabs

@StefanoFioravanzo with 8b3b40e revised as follows:

  • "Model Development" bidirectional: I can totally see the interactivity in both directions, especially during "inner loops" iterations
  • "Model Serving" the direction was mean to flow from Model Registry, to KServe

I've left the other arrows unchanged, since in those automated components I would expect the components to index/catalog the result into the Model Registry

tarilabs avatar Jul 29 '24 12:07 tarilabs

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, ederign, rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Aug 06 '24 19:08 google-oss-prow[bot]

All comments in this PR looks addressed to me, and socialized this PR with all the folks who had original comments (links in first message) that this PR is meant to follow-up on--as agreed.

/remove-hold

tarilabs avatar Aug 07 '24 06:08 tarilabs