website icon indicating copy to clipboard operation
website copied to clipboard

Moved multi-user to KFP v2 docs

Open hbelmiro opened this issue 1 year ago • 12 comments

Resolves: https://github.com/kubeflow/website/issues/3749

cc @chensun

hbelmiro avatar Jul 01 '24 21:07 hbelmiro

/lgtm

rimolive avatar Jul 01 '24 21:07 rimolive

/lgtm /approve

rimolive avatar Jul 04 '24 14:07 rimolive

cc @jbottum For some reason this specific PR requested your approval. Can you help us in here?

rimolive avatar Jul 04 '24 14:07 rimolive

sure, but I am not sure I understand it. It looks like just a documentation change. Have the KFP WG leads commented ? are they on PTO ?

jbottum avatar Jul 04 '24 16:07 jbottum

@jbottum this PR changes the content/en/_redirects. This file doesn't belong to the pipelines folder. That's why it needs approval from root approvers.

hbelmiro avatar Jul 04 '24 17:07 hbelmiro

/hold

hbelmiro avatar Jul 09 '24 15:07 hbelmiro

/unhold

@terrytangyuan can you also take a look? We need a root approver.

hbelmiro avatar Jul 09 '24 16:07 hbelmiro

@terrytangyuan @jbottum @andreyvelich @james-jwu can one of you guys take a look? We need a root approver.

hbelmiro avatar Jul 15 '24 13:07 hbelmiro

/hold

hbelmiro avatar Jul 15 '24 18:07 hbelmiro

/unhold

hbelmiro avatar Jul 15 '24 19:07 hbelmiro

/approve

zijianjoy avatar Aug 14 '24 17:08 zijianjoy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Aug 14 '24 17:08 google-oss-prow[bot]

/lgtm

rimolive avatar Aug 14 '24 17:08 rimolive