website icon indicating copy to clipboard operation
website copied to clipboard

Add missing import to containerized pipelines example

Open tom1299 opened this issue 1 year ago • 3 comments

The import for compiler was missing.

tom1299 avatar Jun 25 '24 12:06 tom1299

Hi @tom1299. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow[bot] avatar Jun 25 '24 12:06 google-oss-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign neuromage for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jun 25 '24 12:06 google-oss-prow[bot]

/ok-to-test

hbelmiro avatar Jun 25 '24 12:06 hbelmiro

@hbelmiro can you approve?

varodrig avatar Dec 07 '24 05:12 varodrig

@tom1299 can you please rebase?

hbelmiro avatar Dec 09 '24 12:12 hbelmiro

@hbelmiro Looking at the merge conflicts it seems that the changes from my PR are already part of https://github.com/kubeflow/website/commit/d9ae92b1c43be3dbb332bc106617a4e231011273 So it doesn't really make any sense to merge this PR anymore. Closing it.

tom1299 avatar Dec 10 '24 06:12 tom1299