website icon indicating copy to clipboard operation
website copied to clipboard

Fix links to machine types and kustomize configuration

Open tom1299 opened this issue 1 year ago • 3 comments

Update of two links to machines types and kustomize.

tom1299 avatar Jun 10 '24 09:06 tom1299

Hi @tom1299. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow[bot] avatar Jun 10 '24 09:06 google-oss-prow[bot]

/ok-to-test /lgtm

@chensun can you PTAL?

hbelmiro avatar Jun 10 '24 11:06 hbelmiro

@tom1299 can you please rebase?

hbelmiro avatar Dec 06 '24 18:12 hbelmiro

content is still valid, but needs to be moved to https://www.kubeflow.org/docs/components/pipelines/legacy-v1/installation/standalone-deployment/ @tom1299 can you please make this update? thank you cc @hbelmiro

varodrig avatar Dec 14 '24 04:12 varodrig

I'm sorry but I accidentally closed the PR while doing the changes. I moved the changes to the legacy documentation.

tom1299 avatar Dec 16 '24 07:12 tom1299

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Dec 16 '24 10:12 google-oss-prow[bot]