training-operator icon indicating copy to clipboard operation
training-operator copied to clipboard

update contributing guide for trainer v2

Open burhanuddin6 opened this issue 9 months ago • 4 comments

What this PR does / why we need it: Updates the Contributing Setup and Testing Guide from V1 to Kubeflow Trainer V2. Replaces older instructions by correct instructions for each section in the original Contributing.md file Checklist:

  • [ ] Docs included if any changes are user facing

burhanuddin6 avatar Mar 23 '25 10:03 burhanuddin6

Update the `newTag` key in `./manifests/overlayes/standalone/kustimization.yaml` with the new image.

I think this is unnecessary and should be removed

burhanuddin6 avatar Mar 23 '25 10:03 burhanuddin6

@andreyvelich @franciscojavierarceo @Electronic-Waste review requested. I see the other PRs have some parts missing which I have done

burhanuddin6 avatar Mar 24 '25 06:03 burhanuddin6

Pull Request Test Coverage Report for Build 14018198395

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.403%

Totals Coverage Status
Change from base Build 13991199064: 0.0%
Covered Lines: 1688
Relevant Lines: 2621

💛 - Coveralls

coveralls avatar Mar 24 '25 11:03 coveralls

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Mar 31 '25 14:03 google-oss-prow[bot]

closing this PR since a new PR has been made here which rebases to the current updated CONTRIBUTING.md.

burhanuddin6 avatar Mar 31 '25 16:03 burhanuddin6