training-operator test(runtime): add UT for jobset runtime valid function.

What this PR does / why we need it: Add fine grained UT for jobset runtime Validate function.

Which issue(s) this PR fixes Fixes #2556

Checklist:

[ ] Docs included if any changes are user facing

Mar 23 '25 10:03 Harshal292004

@tenzen-y Could you please look into this PR fixing #2556 Jobset UTs

Mar 23 '25 10:03 Harshal292004

/ok-to-test /rerun-all

Mar 25 '25 08:03 IRONICBo

@IRONICBo I updated the entire test . Can you have a look

Mar 25 '25 15:03 Harshal292004

@tenzen-y I have removed the test case where runtimeInfo is nil it's causing panic when accessing ReplicatedJobs from jobSetSpec. Other test cases are passing successfully

Mar 26 '25 02:03 Harshal292004

cc @IRONICBo @Electronic-Waste @jinchihe

Mar 26 '25 02:03 Harshal292004

/rerun-all

Mar 26 '25 03:03 IRONICBo

Pull Request Test Coverage Report for Build 14470201388

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 67.356%

Totals
Change from base Build 14412786058:	0.9%
Covered Lines:	1758
Relevant Lines:	2610

💛 - Coveralls

Mar 26 '25 03:03 coveralls

/rerun-all

Mar 26 '25 04:03 Harshal292004

@IRONICBo Can you please rerun the workflows there was a gci error in the last run

Mar 26 '25 04:03 Harshal292004

/rerun-all

Mar 26 '25 08:03 IRONICBo

@IRONICBo Can you please rerun the workflows there was a gci error in the last run

OK

Mar 26 '25 08:03 IRONICBo

Thank you! /lgtm

Mar 27 '25 02:03 IRONICBo

Hi @IRONICBo ,

I recently raised two PRs for Kubeflow Trainer, both of which passed all checks. One of them was reviewed by @tenzen-y , but it hasn’t been merged yet as no approvals or suggestions were provided by the reviewers.

Could you clarify if there’s a specific process for PRs to get merged? Should I wait for approval, or is there something I should do to get more reviewer attention?

Mar 27 '25 03:03 Harshal292004

Hi @IRONICBo ,

I recently raised two PRs for Kubeflow Trainer, both of which passed all checks. One of them was reviewed by @tenzen-y , but it hasn’t been merged yet as no approvals or suggestions were provided by the reviewers.

Could you clarify if there’s a specific process for PRs to get merged? Should I wait for approval, or is there something I should do to get more reviewer attention?

I am not sure, and you may need to wait for other reviewers to process it, other reviews may be busy with other threads.

Mar 27 '25 06:03 IRONICBo

@tenzen-y Could you please review this PR ?

Mar 31 '25 05:03 Harshal292004

@tenzen-y Updated everything as suggested

Apr 15 '25 13:04 Harshal292004

@tenzen-y, I was wondering if there are any significant opportunities for contribution within Kubeflow at the moment? @Electronic-Waste is currently focused on KEP 2401, so there isn’t much for me to do in that area.

Apr 15 '25 13:04 Harshal292004

@tenzen-y, I was wondering if there are any significant opportunities for contribution within Kubeflow at the moment? @Electronic-Waste is currently focused on KEP 2401, so there isn’t much for me to do in that area.

Every contribution is valuable. If you have an interest in any feature development, please contact the issue creator.

Apr 15 '25 13:04 tenzen-y

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Apr 15 '25 13:04 google-oss-prow[bot]