training-operator
training-operator copied to clipboard
Get and Use TrainingRuntime ApplyConfiguration throughout KF PipelineFramework
What you would like to be added?
Instead of typed TrainingRuntime, we want to get ApplyConfiguration TrainingRuntime, and then reuse it in the whole of KF Pipeline Framework processes
https://github.com/kubeflow/trainer/blob/b89ce8491ff81b8b01513e26d0a917808b6eed89/pkg/runtime/core/trainingruntime.go#L75-L79
Why is this needed?
In the SSA semantics, zero and null have completely different meanings. However, converting from typed object to ApplyConfiguration can not recognize the differences. This indicates the KF Pipeline Framework might accidentally remove any fields during SSA PATCH.
Love this feature?
Give it a 👍 We prioritize the features with most 👍
/assign cc @astefanutti
/area controller
@tenzen-y May I work on this Issue ? I researched a bit still I am unable to understand from where do I get ApplyConfiguration from. I checked the k8s API as well.
@tenzen-y May I work on this Issue ? I researched a bit still I am unable to understand from where do I get ApplyConfiguration from. I checked the
k8s APIas well.
As you can see in assigner, I'm currently working on this.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
/remove-lifecycle stale
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
/remove-lifecycle stale
/unassign /assign @astefanutti
@astefanutti Thank you for taking this one!