training-operator icon indicating copy to clipboard operation
training-operator copied to clipboard

Get and Use TrainingRuntime ApplyConfiguration throughout KF PipelineFramework

Open tenzen-y opened this issue 8 months ago • 4 comments

What you would like to be added?

Instead of typed TrainingRuntime, we want to get ApplyConfiguration TrainingRuntime, and then reuse it in the whole of KF Pipeline Framework processes

https://github.com/kubeflow/trainer/blob/b89ce8491ff81b8b01513e26d0a917808b6eed89/pkg/runtime/core/trainingruntime.go#L75-L79

Why is this needed?

In the SSA semantics, zero and null have completely different meanings. However, converting from typed object to ApplyConfiguration can not recognize the differences. This indicates the KF Pipeline Framework might accidentally remove any fields during SSA PATCH.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

tenzen-y avatar Mar 13 '25 04:03 tenzen-y

/assign cc @astefanutti

tenzen-y avatar Mar 13 '25 04:03 tenzen-y

/area controller

tenzen-y avatar Mar 15 '25 08:03 tenzen-y

@tenzen-y May I work on this Issue ? I researched a bit still I am unable to understand from where do I get ApplyConfiguration from. I checked the k8s API as well.

Harshal292004 avatar Mar 21 '25 05:03 Harshal292004

@tenzen-y May I work on this Issue ? I researched a bit still I am unable to understand from where do I get ApplyConfiguration from. I checked the k8s API as well.

As you can see in assigner, I'm currently working on this.

tenzen-y avatar Mar 21 '25 05:03 tenzen-y

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 19 '25 10:06 github-actions[bot]

/remove-lifecycle stale

andreyvelich avatar Jun 26 '25 12:06 andreyvelich

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 24 '25 15:09 github-actions[bot]

/remove-lifecycle stale

astefanutti avatar Sep 24 '25 15:09 astefanutti

/unassign /assign @astefanutti

@astefanutti Thank you for taking this one!

tenzen-y avatar Oct 07 '25 15:10 tenzen-y