training-operator icon indicating copy to clipboard operation
training-operator copied to clipboard

Add a workflow for publishing Helm charts

Open ChenYi015 opened this issue 9 months ago • 6 comments

What you would like to be added?

Add a GitHub action workflow for:

  • Publishing helm charts to GHCR, so user can install the trainer Helm chart by specifying OCI image repository and version:

    helm install kubeflow-trainer oci://ghcr.io/kubeflow/helm-charts/kubeflow-trainer
        --version 2.0.0 \
        --namespace kubeflow-system \
        --create-namespace
    
  • (Optional) Using GH page to host the Helm charts index file index.yaml, so users are able to add trainer as a Helm chart repo like:

    helm repo add kubeflow-trainer https://kubeflow.github.io/trainer
    

    In this way, users only need to add the Helm repo once and then they can:

    # Update Helm repo index
    helm repo update
    
    # Search repo for available versions of kubeflow-trainer
    helm search repo kubeflow-trainer --versions
    
    # Install the latest version
    helm install kubeflow-trainer kubeflow-trainer/kubeflow-trainer \
        --namespace kubeflow-system \
        --create-namespace
    
    # Install a specified version
    helm install kubeflow-trainer kubeflow-trainer/kubeflow-trainer \
        --version 2.0.0 \
        --namespace kubeflow-system \
        --create-namespace
    

Why is this needed?

Set a workflow to publish Helm charts automatically.

Love this feature?

Give it a šŸ‘ We prioritize the features with most šŸ‘

ChenYi015 avatar Mar 07 '25 06:03 ChenYi015

/remove-label lifecycle/needs-triage /good-first-issue /area deployment

andreyvelich avatar Mar 13 '25 15:03 andreyvelich

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/remove-label lifecycle/needs-triage /good-first-issue /area deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Mar 13 '25 15:03 google-oss-prow[bot]

Hey I was looking to contribute to this issue. Can I start working on it?

RasButAss avatar Mar 13 '25 18:03 RasButAss

Sure, thank you for your time @RasButAss! While we are finalizing the Helm Chart PR, you can start working on GitHub action to publish it: https://github.com/kubeflow/trainer/pull/2435 /assign @RasButAss

andreyvelich avatar Mar 14 '25 02:03 andreyvelich

Hello @RasButAss , are you still working on this issue? Would love to work on this issue.

izuku-sds avatar Mar 26 '25 21:03 izuku-sds

/assign

izuku-sds avatar Mar 29 '25 04:03 izuku-sds

Hi I am looking to contribute to this project, is this issue still open?

kris-gaudel avatar May 31 '25 20:05 kris-gaudel

Sure, that would be great @kris-gaudel! @izuku-sds Are you still working on this PR, or @kris-gaudel can take it over: https://github.com/kubeflow/trainer/pull/2571 ?

andreyvelich avatar Jun 02 '25 15:06 andreyvelich

@andreyvelich if this issue is still actively being worked on, do you have any issues you'd recommend for a beginner like myself?

kris-gaudel avatar Jun 02 '25 15:06 kris-gaudel

Hi @andreyvelich , due to other commitments, I’m currently unable to continue working on this issue. I’d be happy for @kris-gaudel to take it over. Some initial work has been done in PR #2571 — feel free to refer to it,

izuku-sds avatar Jun 02 '25 15:06 izuku-sds

/unassign @izuku-sds

/assign @kris-gaudel

andreyvelich avatar Jun 02 '25 15:06 andreyvelich

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 31 '25 20:08 github-actions[bot]

@kris-gaudel Are you still working on this issue ? /remove-lifecycle stale

andreyvelich avatar Sep 01 '25 12:09 andreyvelich

Unfortunately I'm not anymore

kris-gaudel avatar Sep 02 '25 20:09 kris-gaudel

/unassign @kris-gaudel

kris-gaudel avatar Sep 02 '25 20:09 kris-gaudel

/good-first-issue /help

andreyvelich avatar Sep 02 '25 20:09 andreyvelich

We are still looking for contributors to help us with publishing Helm Charts for KF Trainer. /good-first-issue

andreyvelich avatar Oct 07 '25 18:10 andreyvelich

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

We are still looking for contributors to help us with publishing Helm Charts for KF Trainer. /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Oct 07 '25 18:10 google-oss-prow[bot]

@adity1raut If you are interested, feel free to take over this issue! @izuku-sds Has pending PR that you should just finalize: https://github.com/kubeflow/trainer/pull/2571

andreyvelich avatar Oct 15 '25 18:10 andreyvelich

@adity1raut If you are interested, feel free to take over this issue! @izuku-sds Has pending PR that you should just finalize: #2571

Yes @andreyvelich Please Assign me

adity1raut avatar Oct 15 '25 18:10 adity1raut

/assign

adity1raut avatar Oct 15 '25 18:10 adity1raut

Hi @adity1raut, are you still working on publishing Trainer Helm Charts ? It would be great to have charts published, so users can use Helm to install KF Trainer v2.1 cc @kubeflow/kubeflow-trainer-team

andreyvelich avatar Oct 21 '25 15:10 andreyvelich

Hi @adity1raut, are you still working on publishing Trainer Helm Charts ? It would be great to have charts published, so users can use Helm to install KF Trainer v2.1 cc @kubeflow/kubeflow-trainer-team

Yes @andreyvelich

adity1raut avatar Oct 22 '25 07:10 adity1raut

Sounds great @adity1raut! We are planning to release v2.1 by end of October, so it would be good to include this feature.

andreyvelich avatar Oct 22 '25 15:10 andreyvelich

/milestone v2.1

andreyvelich avatar Oct 22 '25 15:10 andreyvelich

Hi @adity1raut, do we have any updates for the Helm publishing PR ?

andreyvelich avatar Oct 29 '25 08:10 andreyvelich

Fixed by: https://github.com/kubeflow/trainer/pull/2906 /close

andreyvelich avatar Nov 03 '25 16:11 andreyvelich

@andreyvelich: Closing this issue.

In response to this:

Fixed by: https://github.com/kubeflow/trainer/pull/2906 /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Nov 03 '25 16:11 google-oss-prow[bot]