Add Initialized and ComponentsCreated conditions to TrainJob API
This PR adds Initialized and ComponentsCreated conditions to the TrainJob API to better track the state of job creation and initialization.
- Added
Initializedcondition to indicate when the TrainJob has been initialized. - Added
ComponentsCreatedcondition to indicate when the components (e.g., JobSet, Jobs) have been created. - Updated the controller logic to set these conditions during reconciliation.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@ tenzen-y
can you check my PR where I added some feature .
Hi @dineshkolhe1, as we discussed in this issue we would like to remove the Created condition for now and only keep Complete and Failed: https://github.com/kubeflow/trainer/issues/2459 So we won't introduce the breaking changes in the future:
Please can you help us with that ?
cc @tenzen-y @Electronic-Waste @astefanutti
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.