training-operator icon indicating copy to clipboard operation
training-operator copied to clipboard

KEP-2170: Add Kubeflow Trainer Pipeline Framework Concept page to Documentation

Open tenzen-y opened this issue 9 months ago • 7 comments

What you would like to be added?

It would be great to add Kubeflow TrainerPipelineFramework documentations to https://www.kubeflow.org/docs/components/trainer/operator-guides/

Why is this needed?

We documentized the Kubeflow TrainerPipelineFramework overview and mechanism in the design documentation: https://github.com/kubeflow/trainer/blob/aece6335609e4b20abb62bdabadac30c16713d74/docs/proposals/2170-kubeflow-training-v2/README.md#pipeline-framework

It would be great to add similar documentation that is more user-friendly.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

tenzen-y avatar Feb 28 '25 20:02 tenzen-y

@tenzen-y
basically you will trying to say the documentation which have in the Kubeflow TrainerPipelineFramework thise will also have in - https://www.kubeflow.org/docs/components/trainer/operator-guides/ here.

dineshkolhe1 avatar Mar 01 '25 13:03 dineshkolhe1

@dineshkolhe1 Yes, we should create a new page in operator guides which describe the Kubeflow Trainer pipeline framework functionality. /area docs /good-first-issue

andreyvelich avatar Mar 03 '25 21:03 andreyvelich

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

@dineshkolhe1 Yes, we should create a new page in operator guides which describe the Kubeflow Trainer pipeline framework functionality. /area docs /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Mar 03 '25 21:03 google-oss-prow[bot]

@tenzen-y basically you will trying to say the documentation which have in the Kubeflow TrainerPipelineFramework thise will also have in - https://www.kubeflow.org/docs/components/trainer/operator-guides/ here.

yeah, thats's right!

tenzen-y avatar Mar 03 '25 22:03 tenzen-y

@tenzen-y Can you assign it to me? I'm learning about trainer v1 volcano and trainer v2 related concepts, this might be a good opportunity for me to familiarize myself with v2 documentation.

It seems to me that the job of this issue should be to migrate docs/proposals/2170-kubeflow-training-v2/README.md TrainerPipelineFramework under kubeflow/website/content/en/docs/components/trainer/operator-guides, is it right?

IRONICBo avatar Mar 04 '25 01:03 IRONICBo

/assign @IRONICBo

It seems to me that the job of this issue should be to migrate docs/proposals/2170-kubeflow-training-v2/README.md TrainerPipelineFramework under kubeflow/website/content/en/docs/components/trainer/operator-guides, is it right?

It shouldn't be just a migration, we should discuss what doc we want to add for operator-guides in Kubeflow website.

andreyvelich avatar Mar 04 '25 17:03 andreyvelich

I see, at the moment it seems that operator-guides is missing documentation for the training api, migration, etc. under 2170-kubeflow-training-v2. Maybe introduce the TrainerPipelineFramework into the website first to introduce the core flow of the V2 pipeline.

Beside, for users, the description of TrainerPipelineFramework may need to be touched up.

IRONICBo avatar Mar 05 '25 01:03 IRONICBo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 03 '25 05:06 github-actions[bot]

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Jun 23 '25 05:06 github-actions[bot]

/reopen

tenzen-y avatar Jun 23 '25 13:06 tenzen-y

@tenzen-y: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Jun 23 '25 13:06 google-oss-prow[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 21 '25 20:09 github-actions[bot]

This has been added here: https://github.com/kubeflow/website/pull/4039 /close

andreyvelich avatar Sep 23 '25 14:09 andreyvelich

@andreyvelich: Closing this issue.

In response to this:

This has been added here: https://github.com/kubeflow/website/pull/4039 /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Sep 23 '25 14:09 google-oss-prow[bot]