training-operator icon indicating copy to clipboard operation
training-operator copied to clipboard

Update Dockerfile with python debian image in cmd/initializer_v2/dataset/Dockerfile

Open mani1soni opened this issue 1 year ago • 9 comments

Updated Dockerfile with python debian image for resolving issue :- "Use Debian images for Python components in the Training Operator V2 #2311" in this dockerfile - cmd/initializer_v2/dataset/Dockerfile

What this PR does / why we need it: This PR replaces the docker image from "python:3.11-alpine" to "python:3.11-slim-bookworm". As per the comment #2303.

Which issue(s) this PR fixes This PR Fixes #2311 issue.

mani1soni avatar Oct 28 '24 13:10 mani1soni

Pull Request Test Coverage Report for Build 11554548437

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11542660312: 0.0%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls

coveralls avatar Oct 28 '24 19:10 coveralls

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Oct 28 '24 19:10 google-oss-prow[bot]

/hold

andreyvelich avatar Oct 28 '24 19:10 andreyvelich

@mani1soni Thank you for this! Please can you also update the model initializer script and verify locally that this images is working with HF snapshot download API ?

andreyvelich avatar Oct 28 '24 19:10 andreyvelich

@mani1soni Thank you for this! Please can you also update the model initializer script and verify locally that this images is working with HF snapshot download API ?

Sure @andreyvelich, I'll check that.

mani1soni avatar Oct 29 '24 08:10 mani1soni

Hi @mani1soni, did you get a chance to update the rest Docker images ?

andreyvelich avatar Nov 30 '24 01:11 andreyvelich

Hi @mani1soni, did you get a chance to update the rest Docker images ?

Hi @andreyvelich , I checked them. I’ll update the code by tomorrow. Thanks

mani1soni avatar Nov 30 '24 04:11 mani1soni

Hi @mani1soni, any chance you can update it ? Otherwise, we can delegate this task to other contributors.

andreyvelich avatar Jan 26 '25 18:01 andreyvelich

/assign

Debabrata47 avatar Mar 14 '25 11:03 Debabrata47

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 12 '25 15:06 github-actions[bot]

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Jul 02 '25 20:07 github-actions[bot]