training-operator icon indicating copy to clipboard operation
training-operator copied to clipboard

[SDK] test: add unit test for list_jobs method of the training_client

Open seanlaii opened this issue 1 year ago • 2 comments

What this PR does / why we need it: New unit test for list_jobs function

To verify run:

pytest -v sdk/python/kubeflow/training/api/training_client_test.py -k test_list_jobs

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): Ref: #2161

Checklist:

  • [ ] Docs included if any changes are user facing

seanlaii avatar Sep 23 '24 02:09 seanlaii

Pull Request Test Coverage Report for Build 11155962731

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11114598546: 0.0%
Covered Lines: 66
Relevant Lines: 66

💛 - Coveralls

coveralls avatar Sep 23 '24 16:09 coveralls

@seanlaii Please rebase your PR.

andreyvelich avatar Sep 30 '24 21:09 andreyvelich

@seanlaii Please rebase your PR.

Rebased. Please help take a look. Thank you.

seanlaii avatar Sep 30 '24 23:09 seanlaii

Thanks for the update @seanlaii! /lgtm /approve

andreyvelich avatar Oct 03 '24 11:10 andreyvelich

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Oct 03 '24 11:10 google-oss-prow[bot]