training-operator
training-operator copied to clipboard
Stop overriding the `GetPodsForJob` of the `JobController`
Currently, all framework-job-controller override the GetPodsForJob of the JobController:
- JobController (is overridden): https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/common/pod.go#L217
- mpijob-controller: https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/mpi/mpijob_controller.go#L508
- mxnetjob-controller: https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/mxnet/mxjob_controller.go#L289
- paddlejob-controller: https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go#L284
- pytorchjob-controller: https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/pytorch/pytorchjob_controller.go#L284
- tfjob-controller: https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/tensorflow/tfjob_controller.go#L291
- xgboostjob-controller: https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/xgboost/xgboostjob_controller.go#L294
Maybe, we can commonize the logic and stop overriding the method in all framework-job-controller.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
/lifecycle frozen