training-operator icon indicating copy to clipboard operation
training-operator copied to clipboard

Refactor tests for tfjob-controller

Open tenzen-y opened this issue 2 years ago • 2 comments

Currently, we have many duplicated tests for the tfjob-controller, which are flaky.

For example, we have duplicated tests for Job:

  • https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/tensorflow/job_test.go#L42
  • https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/tensorflow/tfjob_controller_test.go#L32

So, we should refactor those tests and then implement tests like PyTorchJob:

https://github.com/kubeflow/training-operator/blob/59cc98cbfc906546b096a29f5d31482fba7cdebf/pkg/controller.v1/pytorch/pytorchjob_controller_test.go

tenzen-y avatar Jul 05 '23 18:07 tenzen-y

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 03 '23 20:10 github-actions[bot]

/lifecycle frozen

tenzen-y avatar Oct 05 '23 04:10 tenzen-y