training-operator icon indicating copy to clipboard operation
training-operator copied to clipboard

Published 20 hours ago • verified publisher icon kubeflow

Refactor mpijob-controller

Open tenzen-y opened this issue 2 years ago • 7 comments

Currently, the mpijob-controller has logic similar to kubeflow/common by oneself since the mpijob-controller does not depend on kubeflow/common.

So when we want to fix or add controller logic, we must apply the same patches to kubeflow/common and mpijob-controller.

Since that is a high maintenance cost, it might be better to refactor the mpijob-controller using kubeflow/common.

tenzen-y avatar Jan 17 '23 06:01 tenzen-y

/kind feature

tenzen-y avatar Jan 17 '23 06:01 tenzen-y

Great idea.

terrytangyuan avatar Jan 17 '23 06:01 terrytangyuan

Related: #1714

johnugeorge avatar Jan 17 '23 07:01 johnugeorge

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 23 '23 20:08 github-actions[bot]

/remove-lifecycle stale

tenzen-y avatar Aug 24 '23 13:08 tenzen-y

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 22 '23 15:11 github-actions[bot]

/lifecycle frozen

tenzen-y avatar Nov 23 '23 18:11 tenzen-y