Inconsistent implementation in UpdateJobStatusInApiServer method

[HeGaoYuan]

In the following codes, they are UpdateJobStatusInApiServer method implementation in different Job. They are very similar but different. It is very confusing when programmers read the codes.

1. Does trainingoperatorcommon.ClearGeneratedFields() method need?
2. Does reflect.DeepEqual() method need?
3. What is the difference between reflect.DeepEqual() and equality.Semantic.DeepEqual()?
4. Does jc.Log.WithValues() need? It seems did nothing.

Referring to point4 of https://github.com/kubeflow/training-operator/issues/1703

https://github.com/kubeflow/training-operator/blob/e13d262fe4fabd548ded944e5356c99f30a33b00/pkg/controller.v1/mpi/mpijob_controller.go#L646-L678

https://github.com/kubeflow/training-operator/blob/e13d262fe4fabd548ded944e5356c99f30a33b00/pkg/controller.v1/mxnet/mxjob_controller.go#L430-L451

https://github.com/kubeflow/training-operator/blob/e13d262fe4fabd548ded944e5356c99f30a33b00/pkg/controller.v1/pytorch/pytorchjob_controller.go#L483-L511

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[andreyvelich]

cc @johnugeorge @tenzen-y @kuizhiqing

[tenzen-y]

/remove-lifecycle stale

Yes, we should refactor the UpdateJobStatusInApiServer.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[andreyvelich]

/lifecycle frozen