spark-operator icon indicating copy to clipboard operation
spark-operator copied to clipboard

Draft: fix the minResources calculation logic of podgroup for volcano

Open kaka-zb opened this issue 1 year ago • 2 comments

Purpose of this PR

As described in #2244, the spark.dynamicAllocation.* & spark.kubernetes.memoryOverheadFactor params of spark are not taken into account when calculating memory of minResources for volcano podGroup, so i created this PR and see if that helps. And then we can consider extracting resourceusage module to the scheduler directory.

Note that only cluster deploy mode is considered in this PR, after resourceusage module is extracted, i can import resourceusage module in volcano package and fix the minResources calculation logic in both cluster deploy mode and client deploy mode.

kaka-zb avatar Oct 18 '24 09:10 kaka-zb

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign yuchaoran2011 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Oct 18 '24 09:10 google-oss-prow[bot]

@jacobsalway, please take a look when you're free

kaka-zb avatar Oct 18 '24 09:10 kaka-zb

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 17 '25 10:01 github-actions[bot]

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Feb 06 '25 10:02 github-actions[bot]