spark-operator Add extraEnv value

Add extraEnv value

Open Aransh opened this issue 4 months ago • 4 comments

Purpose of this PR

Allow passing additional env vars directly to the operator.

Proposed changes:

Add extraEnv value to values.yaml, default empty

Change Category

Indicate the type of change by marking the applicable boxes:

[ ] Bugfix (non-breaking change which fixes an issue)
[x] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that could affect existing functionality)
[ ] Documentation update

Rationale

To add overriding env vars such as KUBERNETES_CONNECTION_TIMEOUT

Checklist

Before submitting your PR, please review the following:

[x] I have conducted a self-review of my own code.
[x] I have updated documentation accordingly.
[ ] I have added tests that prove my changes are effective or that my feature works.
[x] Existing unit tests pass locally with my changes.

Additional Notes

Apr 16 '24 08:04 Aransh

Thanks for the details. Could you please make sure that checks pre-commit checks are passing?

Apr 17 '24 17:04 vara-bonthu

@vara-bonthu bumped version for this and https://github.com/kubeflow/spark-operator/pull/1986

Apr 17 '24 18:04 Aransh

I'm not sure if this change is needed. There's an existing envFrom field that can add content of a configmap as environment variables

Yes, but then I have to manage a separate configmap just for a small env variable change, makes bootstrapping on new clusters needlessly more difficult

Apr 17 '24 20:04 Aransh

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aransh Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: