spark-operator
spark-operator copied to clipboard
Add extraEnv value
Purpose of this PR
Allow passing additional env vars directly to the operator.
Proposed changes:
- Add extraEnv value to values.yaml, default empty
Change Category
Indicate the type of change by marking the applicable boxes:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] Feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that could affect existing functionality)
- [ ] Documentation update
Rationale
To add overriding env vars such as KUBERNETES_CONNECTION_TIMEOUT
Checklist
Before submitting your PR, please review the following:
- [x] I have conducted a self-review of my own code.
- [x] I have updated documentation accordingly.
- [ ] I have added tests that prove my changes are effective or that my feature works.
- [x] Existing unit tests pass locally with my changes.
Additional Notes
Thanks for the details. Could you please make sure that checks pre-commit checks are passing?
@vara-bonthu bumped version for this and https://github.com/kubeflow/spark-operator/pull/1986
I'm not sure if this change is needed. There's an existing envFrom field that can add content of a configmap as environment variables
Yes, but then I have to manage a separate configmap just for a small env variable change, makes bootstrapping on new clusters needlessly more difficult
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Aransh Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Aransh Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment