spark-operator icon indicating copy to clipboard operation
spark-operator copied to clipboard

BUGFIX: Added cancel method to fix context leak

Open fazledyn-or opened this issue 1 year ago • 0 comments

This PR fixes a context leak bug in your code.

Summary

While triaging your project, our bug fixing tool generated the following message-

In file: event.go, method context.WithTimeout is called where the returned cancel function is ignored. It is suggested that the returned cancel function shouldn't be ignored.

Details

In the line below, a context is created using the WithTimeout method, where the returned cancelFunc handler is ignored.

ctx, _ = context.WithTimeout(ctx, watchExpire)

I have introduced the cancel handler and deferred it so that once the method Run() completes execution, it can be safely cancelled.

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

fazledyn-or avatar Jan 31 '24 08:01 fazledyn-or