spark-operator icon indicating copy to clipboard operation
spark-operator copied to clipboard

ci: Use GITHUB_OUTPUT envvar instead of set-output command

Open arunsathiya opened this issue 1 year ago • 3 comments

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of ::set-output to "$GITHUB_OUTPUT"

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

arunsathiya avatar Jan 21 '24 02:01 arunsathiya

@arunsathiya Before we proceed with merging, I'd like to confirm a few things:

Have all instances of set-output been replaced where necessary throughout this workflow?

Could you please ensure that the rest of the workflow is compatible with this change, particularly where the changed output is being consumed?

It would be great to see a successful test run evidence of the modified workflow to verify its proper function.

Once these points are checked and confirmed, we should be good to go ahead with the merge.

Thanks for your contribution!

vara-bonthu avatar Apr 14 '24 01:04 vara-bonthu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jun 15 '24 17:06 google-oss-prow[bot]

@arunsathiya Could you sign off the DCO by git commit -s -m "commit message".

ChenYi015 avatar Jun 25 '24 08:06 ChenYi015