kubeflow
Change deprecated v1beta1 CRD to v1
As per helm3's warning:
apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
@orfeas0 could you please bump up the chart version in this PR? Thanks!
Bumped version, but not appVersion. Is this ok?
Looks like the chart integration test failed with the following message:
Error: failed to install CRD crds/sparkoperator.k8s.io_scheduledsparkapplications.yaml: CustomResourceDefinition.apiextensions.k8s.io "scheduledsparkapplications.sparkoperator.k8s.io" is invalid: [spec.versions[0].schema.openAPIV3Schema: Required value: schemas are required, metadata.annotations[api-approved.kubernetes.io]: Required value: protected groups must have approval annotation "api-approved.kubernetes.io", see https://github.com/kubernetes/enhancements/pull/1111]
I don't get the test fail, is it because I'm missing permissions? What's the process?
I don't get the test fail, is it because I'm missing permissions? What's the process?
@orfeas0 @liyinan926
Seems you need to have a PR in kubernetes GitHub then once you have approval you add this annotation:
metadata:
annotations:
"api-approved.kubernetes.io": "https://github.com/kubernetes/kubernetes/pull/PRNUMBER"
I think this is only due to the fact the sparkoperator team used a protected internal URL spec for the CRD spec with:
sparkoperator.k8s.io
If it was just:
sparkoperator.spark.io
then you'd need no such annotation.
So I suppose best idea is to submit a PR or an issue on kubernetes repo and ask them how to proceed. I'll be rooting for you because I need this, but I am not part of the project so not my place to make such a request externally.
I think this is superceded by https://github.com/kubeflow/spark-operator/pull/1298 and can be closed now
