pytorch-operator icon indicating copy to clipboard operation
pytorch-operator copied to clipboard

Published 20 hours ago • verified publisher icon kubeflow

Leverage E2e test framework in tf-operator

Open johnugeorge opened this issue 6 years ago • 7 comments

From https://github.com/kubeflow/pytorch-operator/pull/101#issuecomment-440104646

Investigate how we can leverage e2e test framework in tf-operator

Related: #101

johnugeorge avatar Nov 20 '18 04:11 johnugeorge

/assign Akado2009

Akado2009 avatar Nov 21 '18 06:11 Akado2009

In addition to this, we need to add more tests for different job conditions similar to TF operator

johnugeorge avatar Nov 21 '18 06:11 johnugeorge

@richardsliu Shall we replicate the test framework after modifying for the pytorch operator? Any other options?

johnugeorge avatar Nov 22 '18 04:11 johnugeorge

Can we move the test framework code (test_runner etc) into kubeflow/testing? That way we don't need to replicate the code in every repository.

richardsliu avatar Nov 23 '18 00:11 richardsliu

@jlewi How do you feel about that?

Akado2009 avatar Nov 27 '18 07:11 Akado2009

@richardsliu @jlewi so waht do you think about that? Sounds like a great idea

Akado2009 avatar Dec 19 '18 06:12 Akado2009

The risk of moving test framework code into kubeflow/testing is that if it breaks, all presubmit tests in all repos also break. Fixing the test framework also requires a PR to be merged in kubeflow/testing first, before the changes take effect in kubeflow/tf-operator.

We currently don't have a lot of repos that utilize the Python test framework. Perhaps pytorch can just import the python libraries directly from tf-operator?

richardsliu avatar Dec 19 '18 16:12 richardsliu