pipelines
pipelines copied to clipboard
kubeflow
feat(backend) add maximum_cache_staleness and default_cache_staleness
Description of your changes:
Part of https://github.com/kubeflow/pipelines/pull/8177
Checklist:
- [x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
@juliusvonkohout: you cannot LGTM your own PR.
In response to this:
/lgtm /assign @chensun
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![google-oss-prow[bot] avatar](https://avatars.githubusercontent.com/in/143327?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chensun @james-jwu @zijianjoy as discussed yesterday in the KFP meeting i split off the simple cache changes. Please review and merge.
Thank you @juliusvonkohout! The PR looks good to me, just requesting some small changes.
Thank you @juliusvonkohout! The PR looks good to me, just requesting some small changes.
@linchin is there something else that must be done? I think my new tests are sufficient for the basic functionality.
@juliusvonkohout Thank you for the work! Looks good. /lgtm /cc @chensun @gkcalat
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chensun
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~backend/OWNERS~~ [chensun]
- ~~manifests/kustomize/OWNERS~~ [chensun]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
"2022-10-04 17:05:01 ERROR 503: Egress is over the account limit.." the build systems seems to be overloaded. i will rerun the tests.
V2 is discussed in https://docs.google.com/document/d/1_Hy1_KvuKh-heydg8qIyXYTiMfNPxePx4BHGpZT4xMk/edit?resourcekey=0-PTtkRPF5xpS3lD8dssqX1Q#