feat(frontend): Add pre-check for pipeline and pipeline version name at the UI
There's no naming restriction when creating the pipeline. Currently, using existing pipeline to create a new run will directly use the pipeline and pipeline version name. Subdomains name restriction in kubernates will lead to run creation failure.
Main changes:
- Show error message to the user if the pipeline or pipeline version name is invalid, and then disable the start button.
If the pipeline or pipeline version name not only contains invalid character but also exceed length limit, UI will show length error first.
https://user-images.githubusercontent.com/56132941/183488146-05ec17da-c5e4-40b0-bf4e-e80a8c5ae0b0.mov
We probably cannot change the pipeline name in NewRun pages, because they are already uploaded to the backend. Changing the name on UI will cause no effect when backend creates run. Can you validate what happens if you change the pipeline name from invalid to valid, then create a new run?
Demo: Pipeline name with invalid character or exceeding length will disable the button Pipeline version name only has limit in length.
https://user-images.githubusercontent.com/56132941/183973127-b8f771b4-fff0-48aa-9655-d6a34f11adb5.mov
/test kubeflow-pipeline-frontend-test
/lgtm /approve
Thank you for fixing the issue to prevent failure of run creation!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: zijianjoy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~frontend/OWNERS~~ [zijianjoy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment