pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

feat(frontend): Add pre-check for pipeline and pipeline version name at the UI

Open jlyaoyuli opened this issue 3 years ago • 5 comments

There's no naming restriction when creating the pipeline. Currently, using existing pipeline to create a new run will directly use the pipeline and pipeline version name. Subdomains name restriction in kubernates will lead to run creation failure.

Main changes:

  1. Show error message to the user if the pipeline or pipeline version name is invalid, and then disable the start button.

jlyaoyuli avatar Aug 08 '22 18:08 jlyaoyuli

If the pipeline or pipeline version name not only contains invalid character but also exceed length limit, UI will show length error first.

https://user-images.githubusercontent.com/56132941/183488146-05ec17da-c5e4-40b0-bf4e-e80a8c5ae0b0.mov

jlyaoyuli avatar Aug 08 '22 18:08 jlyaoyuli

We probably cannot change the pipeline name in NewRun pages, because they are already uploaded to the backend. Changing the name on UI will cause no effect when backend creates run. Can you validate what happens if you change the pipeline name from invalid to valid, then create a new run?

zijianjoy avatar Aug 08 '22 21:08 zijianjoy

Demo: Pipeline name with invalid character or exceeding length will disable the button Pipeline version name only has limit in length.

https://user-images.githubusercontent.com/56132941/183973127-b8f771b4-fff0-48aa-9655-d6a34f11adb5.mov

jlyaoyuli avatar Aug 10 '22 17:08 jlyaoyuli

/test kubeflow-pipeline-frontend-test

jlyaoyuli avatar Aug 10 '22 20:08 jlyaoyuli

/lgtm /approve

Thank you for fixing the issue to prevent failure of run creation!

zijianjoy avatar Aug 16 '22 23:08 zijianjoy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Aug 16 '22 23:08 google-oss-prow[bot]