pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

Published 20 hours ago • verified publisher icon kubeflow

fix(backend): set correct permissions for local directory

Open larrytin opened this issue 2 years ago • 8 comments

same problem as https://github.com/kubeflow/pipelines/issues/7213

larrytin avatar Jun 19 '22 05:06 larrytin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign linchin after the PR has been reviewed. You can assign the PR to them by writing /assign @linchin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jun 19 '22 05:06 google-oss-prow[bot]

Hi @larrytin. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Jun 19 '22 05:06 google-oss-prow[bot]

/ok-to-test

juliusvonkohout avatar Jun 28 '22 21:06 juliusvonkohout

/retest-required

larrytin avatar Jul 04 '22 07:07 larrytin

is this related to https://github.com/kubeflow/pipelines/pull/6530 and https://github.com/kubeflow/pipelines/issues/5673 ?

juliusvonkohout avatar Jul 04 '22 11:07 juliusvonkohout

@juliusvonkohout yes, this pull request is enough for me to use a non-root image

larrytin avatar Jul 18 '22 02:07 larrytin

/retest

larrytin avatar Jul 18 '22 02:07 larrytin

@zijianjoy this is important for the 2.0 release then, because otherwise it would be a regression.

juliusvonkohout avatar Jul 18 '22 12:07 juliusvonkohout

What is required to merge this PR? I tested the changes in a restricted k8s environment (OpenShift) and these changes look good. With that, we and kfp-tekton team don't need to create SecurityContextContraint objects if this PR is merged.

rimolive avatar Sep 08 '23 15:09 rimolive

/lgtm

rimolive avatar Sep 12 '23 16:09 rimolive

@rimolive: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Sep 12 '23 16:09 google-oss-prow[bot]

/lgtm

juliusvonkohout avatar Sep 13 '23 12:09 juliusvonkohout

@rimolive You need to join the KFP meeting to push this PR.

juliusvonkohout avatar Sep 13 '23 12:09 juliusvonkohout

@rimolive You need to join the KFP meeting to push this PR.

Thank you, Julius! I've been attending the meetings for a while. I will propose this PR to be reviewed next meeting.

rimolive avatar Sep 13 '23 13:09 rimolive

Same change has merged as https://github.com/kubeflow/pipelines/pull/9946

chensun avatar Oct 10 '23 19:10 chensun