pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

[grpc-gateway] upgrade grpc-gateway to v2

Open hsinhoyeh opened this issue 2 years ago • 4 comments

Feature Area

grpc gateway provides an HTTP way to communicate the underlying GRPC services (defined in the same proto file), and since version v1.14, the community suggests that the v1 is under maintenance mode and suggest to upgrade to v2. https://github.com/grpc-ecosystem/grpc-gateway/releases/tag/v1.14.7 However, the current Kubeflow pipeline is still using v1 (as you can see here https://github.com/kubeflow/pipelines/blob/master/backend/api/hack/generator.sh#L33)

It is well understood that upgrading from v1 to v2 of grpc-gateway might not be straightforward. just wondering that is this need imporoving? or you would need some hands?

/area backend

What feature would you like to see?

use grpc-gateway v2

What is the use case or pain point?

some binaries are gone since v2, it's hard to track them.

Is there a workaround currently?

currently, the upstream of kf pipeine use v1 which is under maintaince mode of grpc-gateway.


Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.

hsinhoyeh avatar May 16 '22 03:05 hsinhoyeh

cc/ @zijianjoy

connor-mccarthy avatar May 19 '22 22:05 connor-mccarthy

Thank you @hsinhoyeh ! Indeed we are still using grpc-gateway v1 and I hope we can upgrade to v2. However, there are breaking changes that I don't have enough bandwidth to look into yet. I am hoping that we can introduce a new API package which can keep this upgrade contained. If you have tried to upgrade, do you know the breaking changes which are caused by upgrading from v1 to v2?

cc @Linchin @annajung @difince

zijianjoy avatar May 29 '22 03:05 zijianjoy

Bumping this issue. Is this still relevant? I'm assuming this was replaced by envoy proxy.

rimolive avatar Mar 12 '24 08:03 rimolive

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 12 '24 07:05 github-actions[bot]

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Jun 03 '24 07:06 github-actions[bot]