fix(deployment): fix custom namespace for viewer crd deployment. Fixes #7714

[markgeejw]

Description of your changes:

Updated the env variable from MINIO_NAMESPACE to NAMESPACE as in backend/Dockerfile.viewercontroller. This fixes an error that happens when you use a custom namespace instead of the default kubeflow, and the ml-pipeline-viewer-crd deployment goes into CrashLoopBackOff.

Checklist:

• [x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[google-oss-prow[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign zijianjoy after the PR has been reviewed. You can assign the PR to them by writing /assign @zijianjoy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• manifests/kustomize/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow[bot]]

Hi @markgeejw. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zijianjoy]

If I understand correctly, the dockerfile is writing kubeflow as environment variable. If you changed the yaml file here, does that mean the viewer crd deployment is still watching kubeflow namespace? But the problem here happens only when you are not deploying KFP standalone in kubeflow namespace.

[markgeejw]

The dockerfile is indeed writing kubeflow as the default value for the environment variable. Changing the yaml file here ensures that we are replacing the correct environment variable, if we use a custom namespace. In this case, viewer crd deployment will watch the custom namespace instead.

Without this, the viewer crd, if deployed in a custom namespace, still watches the kubeflow namespace, which it wont have the correct permissions for, leading the the CrashLoopBackOff described in #7714.

Indeed, this fix is to allow the deployment to work for custom namespaces. It also won't affect if the deployment is to the default kubeflow namespace since the value is read from the current deployment namespace using fieldRef.

[markgeejw]

First time contributing! Do I need to do anything else for this?

[Corea]

Any updates here?

[zijianjoy]

/lgtm /approve

Thank you for the contribution!

[google-oss-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~manifests/kustomize/OWNERS~~ [zijianjoy]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment