pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

[sdk] unarchive_run sets run.storage_state to None instead of STORAGESTATE_ACTIVE

Open dandawg opened this issue 3 years ago • 2 comments

Environment

  • KFP version: 1.4
  • KFP SDK version: 1.8.11
  • All dependencies version: NA

Steps to reproduce

  1. Do a pipeline run:
run = client.create_run_from_pipeline_package(
  pipeline.yaml,
  run_name='my_run',
  experiment_name='my_exp',
  arguments=args
)
result = run.wait_for_run_to_complete()
  1. Archive the run
client.runs.archive_run(result.run.id)
  1. Check that the storage state has transition to STORAGESTATE_ARCHIVED
run_after_archive = client.runs.get_run(result.run.id)
print(run_after_archive.run.storage_state)
  1. Now, unarchive the run, and verify the storage state has transitioned to None
client.runs.unarchive_run(result.run.id)
run_after_unarchive = client.runs.get_run(result.run.id)
print(run_after_unarchive.run.storage_state)

Expected result

When a run is unarchived, the storage state should transition back to STORAGESTATE_ACTIVE. This would be consistent with what I get when I archive, and then subsequently unarchive an experiment using similar commands (client.experiment.archive_experiment, and client.experiment.unarchive_experiment). In the experiment unarchive case, the storage state transitions back to STORAGESTATE_ACTIVE.

Materials and Reference

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

dandawg avatar Mar 22 '22 22:03 dandawg

Could you please archive and then unarchive the run on UI and then check the storage_state from sdk, and see if it behaves the same? Thank you.

Linchin avatar Mar 24 '22 22:03 Linchin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 06 '24 07:05 github-actions[bot]

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar May 28 '24 07:05 github-actions[bot]