pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

fix(backend): cache-deployer generate CSR with wrong usage. fixs #7093

Open jomenxiao opened this issue 3 years ago • 5 comments

Signed-off-by: jomenxiao [email protected]

Description of your changes: Fixed #7093

signerName: kubernetes.io/kube-apiserver-client can not use "server auth", must include "client auth"

Followed by https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests/

Checklist:

jomenxiao avatar Dec 21 '21 09:12 jomenxiao

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign capri-xiyue after the PR has been reviewed. You can assign the PR to them by writing /assign @capri-xiyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Dec 21 '21 09:12 google-oss-prow[bot]

Hi @jomenxiao. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Dec 21 '21 09:12 google-oss-prow[bot]

@jomenxiao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test 129aa1040c70e7ca6d8de7ee57249b382cbd8515 link true /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar Dec 23 '21 01:12 google-oss-prow[bot]

Hi @jomenxiao, not sure are you still working on this. Our team is working on the Kubeflow 1.5 distribution on IBM Cloud and we see this issue on Kubernetes 1.22. Since we want to fix it before the Kubeflow 1.5 release, we added our fixes at PR #7273 that could potentially fix this issue. But feel free to incorporate our changes into this PR since you have this opened first.

Tomcli avatar Feb 08 '22 01:02 Tomcli

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 13 '22 04:06 stale[bot]