pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

feat(deployment): Added support for minio on prem.

Open jacobmalmberg opened this issue 3 years ago • 7 comments

Added an environment for minio on prem that builds on platform-agnostic-multi-user. Only support for one minio endpoint across all namespaces. Support for additional SSL certs. https://github.com/kubeflow/pipelines/pull/5864 must be merged first.

Checklist:

jacobmalmberg avatar Oct 01 '21 17:10 jacobmalmberg

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Oct 01 '21 17:10 google-cla[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign zijianjoy after the PR has been reviewed. You can assign the PR to them by writing /assign @zijianjoy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot avatar Oct 01 '21 17:10 google-oss-robot

Hi @jacobmalmberg. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-robot avatar Oct 01 '21 17:10 google-oss-robot

@googlebot I signed it!

jacobmalmberg avatar Oct 02 '21 07:10 jacobmalmberg

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Oct 02 '21 07:10 google-cla[bot]

@googlebot I fixed it

jacobmalmberg avatar Oct 02 '21 07:10 jacobmalmberg

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 02 '22 12:03 stale[bot]