pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

feat(metadata): ability to get artifacts location for Argo-Workflows v3.0+

Open Subreptivus opened this issue 3 years ago • 6 comments

Starting from this change, Argo-Workflows isn't providing full data (with provider and bucket properties) in outputs annotation by default. With this change metadata_writer will combine artifact file location from the outputs annotation and provider and bucket data from archiveLocation property of the template annotation in case of missing data in outputs annotation.

Subreptivus avatar Jun 10 '21 08:06 Subreptivus

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign ark-kun after the PR has been reviewed. You can assign the PR to them by writing /assign @ark-kun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot avatar Jun 10 '21 08:06 google-oss-robot

Hi @Subreptivus. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-robot avatar Jun 10 '21 08:06 google-oss-robot

Thank you for this contribution.

Ark-kun avatar Jun 11 '21 00:06 Ark-kun

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 02 '22 10:03 stale[bot]

@Subreptivus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-backend-test b2ea6784ec290ea1a91efb5f20251776c269336c link true /test kubeflow-pipeline-backend-test
kubeflow-pipeline-upgrade-test b2ea6784ec290ea1a91efb5f20251776c269336c link true /test kubeflow-pipeline-upgrade-test
kubeflow-pipeline-e2e-test b2ea6784ec290ea1a91efb5f20251776c269336c link true /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar Jul 14 '22 08:07 google-oss-prow[bot]

I'm facing same problem. Using KF version 1.3. Any workaround for now?

Sharathmk99 avatar Jun 12 '23 09:06 Sharathmk99