pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

Missing Markdown support: horizontal rule, emojis

Open jackwhelpton opened this issue 5 years ago • 5 comments

Environment

  • KFP version: 1.0.1

Steps to reproduce

Output a markdown artifact containing the missing features: a horizontal rule, and an emoji, e.g. :warning:

        metadata = {
          "outputs": [
          {
            "storage": "inline",
            "source": "line1\n---\n:warning: Item had multiple genre labels",
            "type": "markdown",
          }]
        }

Expected result

The Visualizations tab and Run output should render the horizontal rule and emoji:

line1

⚠️ Item had multiple genre labels

Instead, the original markup code is visible:

line1 --- :warning: Item had multiple genre labels


Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

jackwhelpton avatar Apr 20 '21 16:04 jackwhelpton

As a workaround, using the character ⚠️ directly works; this doesn't help with, for example, ℹ️ (:information_source:).

This doesn't help with the horizontal rule, either.

jackwhelpton avatar Apr 20 '21 16:04 jackwhelpton

I'm expanding this ticket as I find other missing markdown features: let me know if each one should be spun off as a separate ticket.

jackwhelpton avatar Apr 28 '21 23:04 jackwhelpton

Hello @jackwhelpton , feel free to add more missing markdown features in this ticket. We can update the issue description to match the scope as well. Ideally we should use another markdown render which can fit all markdown feature requests.

https://github.com/kubeflow/pipelines/blob/226079338b38b85ae3b63a5e289c6ca0cd9511d0/frontend/src/components/viewers/MarkdownViewer.tsx#L111-L114

zijianjoy avatar Jul 26 '21 17:07 zijianjoy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 03 '22 00:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 22 '24 07:06 github-actions[bot]

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Jul 14 '24 07:07 github-actions[bot]