pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

fix(frontend): restrict pods API based on namespace access

Open demarna1 opened this issue 3 weeks ago • 3 comments

Description of your changes:

Closes #12509

View the linked issue for additional context and reproduction of the issue.

Test Evidence

User has access to activity in the namespace "serving-test-mlzone" but lacks access to "serving-test-s3":

Screenshot 2025-12-01 at 11 14 05 AM

User is blocked from displaying pod spec, logs, and events from a namespace they don't have access to through the backdoor URL manipulation:

Screenshot 2025-12-02 at 2 03 32 PM Screenshot 2025-12-01 at 10 57 56 AM Screenshot 2025-12-01 at 10 58 39 AM

UI functionality remains the same for users who do have access:

Screenshot 2025-12-01 at 11 14 05 AM (1) Screenshot 2025-12-01 at 11 07 39 AM

Checklist:

demarna1 avatar Dec 05 '25 20:12 demarna1

Hi @demarna1. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Dec 05 '25 20:12 google-oss-prow[bot]

/ok-to-test

JerT33 avatar Dec 09 '25 17:12 JerT33

This is fantastic, @demarna1. Thank you for the contribution.

/lgtm /approve

droctothorpe avatar Dec 17 '25 14:12 droctothorpe

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droctothorpe, zazulam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Dec 17 '25 14:12 google-oss-prow[bot]

New changes are detected. LGTM label has been removed.

google-oss-prow[bot] avatar Dec 17 '25 18:12 google-oss-prow[bot]