pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

Fix: Encapsulate v2/objectstore package to prevent external usage (#12439)

Open suhas-developer07 opened this issue 1 month ago • 3 comments

Summary

This PR addresses issue #12439 by moving the v2/objectstore package into an internal directory.
This ensures the package cannot be imported or used outside the v2 execution engine, aligning with the intended design boundaries.

What This PR Changes

  • Moved backend/src/v2/objectstorebackend/src/v2/internal/objectstore
  • Updated all internal imports accordingly
  • Ensured tests were moved and still function under the new path
  • Removed unused references to the old public package path

Why This Fix Is Necessary

Encapsulating the package ensures:

  • A cleaner internal API boundary
  • Prevention of accidental external dependencies
  • Better long-term maintainability of the v2 execution engine

suhas-developer07 avatar Nov 18 '25 05:11 suhas-developer07

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Nov 18 '25 05:11 google-oss-prow[bot]

Hi @suhas-developer07. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Nov 18 '25 05:11 google-oss-prow[bot]

/ok-to-test

hbelmiro avatar Nov 18 '25 11:11 hbelmiro