feat(frontend): Add an 'Always use latest version option' for recurring runs. Fixes #11581
Description of your changes:
This change introduces a checkbox in the New Run V2 page that allows users to create recurring runs that always use the latest version of a pipeline, without needing to specify a pipeline version ID.
The changes include:
- Added a
useLatestVersionstate variable to track the checkbox's state. - Persisted the
useLatestVersionpreference inlocalStorage. - Modified the
pipeline_version_referencein the API payload to only send thepipeline_idwhenuseLatestVersionis enabled. - Disabled the pipeline version selector when
useLatestVersionis enabled. - Implemented a fallback mechanism to update the Run Name when the checkbox is toggled before a pipeline is selected.
Checklist:
- [x] You have signed off your commits
- [x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @muzzlol. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Thanks for the contribution @muzzlol ! This is looking good.
Could you also please add tests?
Hi @muzzlol @mprahl ,
I fully respect @muzzlol's initial implementation and reasoning. However, since @mprahl has highlighted concrete user benefits for this feature, I'd like to propose a collaborative path forward:
- Preserve your commits (c09bc4e/d74d043) as the foundation
- Address feedback (remove
localStorage, improve UI labels, add tests) - Submit as a new PR with co-authorship attribution to @muzzlol
If you agree, I'll:
- Fork your branch and make incremental changes
- Add you as a co-author in the final commit
- Ensure your original contribution is fully recognized
This way, we can collectively deliver the feature while respecting all perspectives.
/assign
yea @kaikaila sounds good . let me know if you need any help setting up the development enviornment
Hey everyone, just a quick update! I’ve implemented the fix and am currently resolving some final Git branch/sign-off issues. Expecting to submit the PR later today or early tomorrow. Let me know if there’s anything specific you’d like me to double-check before submitting. Thanks