pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

feat(frontend): Add an 'Always use latest version option' for recurring runs. Fixes #11581

Open muzzlol opened this issue 10 months ago • 6 comments

Description of your changes:

This change introduces a checkbox in the New Run V2 page that allows users to create recurring runs that always use the latest version of a pipeline, without needing to specify a pipeline version ID.

The changes include:

  • Added a useLatestVersion state variable to track the checkbox's state.
  • Persisted the useLatestVersion preference in localStorage.
  • Modified the pipeline_version_reference in the API payload to only send the pipeline_id when useLatestVersion is enabled.
  • Disabled the pipeline version selector when useLatestVersion is enabled.
  • Implemented a fallback mechanism to update the Run Name when the checkbox is toggled before a pipeline is selected.

Checklist:

muzzlol avatar Feb 14 '25 02:02 muzzlol

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Feb 14 '25 02:02 google-oss-prow[bot]

Hi @muzzlol. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Feb 14 '25 02:02 google-oss-prow[bot]

Thanks for the contribution @muzzlol ! This is looking good.

Could you also please add tests?

mprahl avatar Mar 04 '25 20:03 mprahl

Hi @muzzlol @mprahl ,

I fully respect @muzzlol's initial implementation and reasoning. However, since @mprahl has highlighted concrete user benefits for this feature, I'd like to propose a collaborative path forward:

  • Preserve your commits (c09bc4e/d74d043) as the foundation
  • Address feedback (remove localStorage, improve UI labels, add tests)
  • Submit as a new PR with co-authorship attribution to @muzzlol

If you agree, I'll:

  1. Fork your branch and make incremental changes
  2. Add you as a co-author in the final commit
  3. Ensure your original contribution is fully recognized

This way, we can collectively deliver the feature while respecting all perspectives.
/assign

kaikaila avatar Mar 10 '25 23:03 kaikaila

yea @kaikaila sounds good . let me know if you need any help setting up the development enviornment

muzzlol avatar Mar 11 '25 02:03 muzzlol

Hey everyone, just a quick update! I’ve implemented the fix and am currently resolving some final Git branch/sign-off issues. Expecting to submit the PR later today or early tomorrow. Let me know if there’s anything specific you’d like me to double-check before submitting. Thanks

kaikaila avatar Mar 13 '25 23:03 kaikaila