pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

fix(backend): fixes upload pipeline version function. Fixes #10825

Open rchojn opened this issue 9 months ago • 2 comments

Introduce fix to upload_pipeline_version function - removed unnecessary all condition.

Checklist:

rchojn avatar May 16 '24 11:05 rchojn

Hi @rchojn. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow[bot] avatar May 16 '24 11:05 google-oss-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 16 '24 11:05 google-oss-prow[bot]

/ok-to-test

hbelmiro avatar May 17 '24 13:05 hbelmiro

@rchojn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests 51c618868a555f3bf15a3f08f5c858253ef68a81 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar May 17 '24 14:05 google-oss-prow[bot]

/retest

rchojn avatar May 20 '24 09:05 rchojn

@hbelmiro is there a way to see a detailed log of this error?

rchojn avatar May 20 '24 14:05 rchojn

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 21 '24 12:05 google-oss-prow[bot]

/retest-required

rchojn avatar May 28 '24 15:05 rchojn

@rchojn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 63fc540e790c9f298e282045105c795faad1896d link true /test kubeflow-pipelines-sdk-execution-tests
kfp-kubernetes-execution-tests 63fc540e790c9f298e282045105c795faad1896d link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar May 28 '24 16:05 google-oss-prow[bot]