pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

feat(GH workflow): migrate postsubmit tests to github actions. Fixes #10747

Open VDliveson opened this issue 9 months ago • 2 comments

Description of your changes: Adds Github actions for postsubmit tests on push to master or release branch. Fixes #10747

Checklist:

cc @rimolive

VDliveson avatar May 16 '24 09:05 VDliveson

Hi @VDliveson. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow[bot] avatar May 16 '24 09:05 google-oss-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 16 '24 09:05 google-oss-prow[bot]

/ok-to-test

hbelmiro avatar May 17 '24 12:05 hbelmiro

@VDliveson have you tried testing this GH Action on your fork? If yes, could you please provide the link to a successful run?

DharmitD avatar May 20 '24 17:05 DharmitD

@DharmitD Kindly also take a look at the periodic functional tests and is there any way to disable it. I've been spammed with 100+ mails with failed workflow. Also the old tests need python 3.7 version but we get this error on python 3.7 image

image

VDliveson avatar May 21 '24 14:05 VDliveson

@VDliveson have you tried testing this GH Action on your fork? If yes, could you please provide the link to a successful run?

https://github.com/VDliveson/pipelines/actions/workflows/postsubmit.yml Running some sample tests

VDliveson avatar May 21 '24 15:05 VDliveson

@DharmitD Kindly also take a look at the periodic functional tests and is there any way to disable it. I've been spammed with 100+ mails with failed workflow. Also the old tests need python 3.7 version but we get this error on python 3.7 image

image

@VDliveson I'm looking into periodic tests GH Action and it looks like it's scheduled to run every 5 minutes, that's the problem. I will bring this up in community but make sure to turn off email notifications for repo GH Actions so it doesn't incessantly ping you with so many notifications.

DharmitD avatar May 21 '24 23:05 DharmitD

@chensun looks like the postsubmit prow config forwards test results to TestGrid: https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-postsubmits.yaml#L14 Do we utilize this notifications’ mechanism? Do we need it in the kind workflows too?

DharmitD avatar May 22 '24 03:05 DharmitD

@DharmitD @rimolive Any updates on this ?

VDliveson avatar Jun 16 '24 07:06 VDliveson

/close as not needed.

hbelmiro avatar Oct 09 '24 12:10 hbelmiro