pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

test: fix CI failure for periodic functional tests

Open tmvfb opened this issue 9 months ago • 4 comments

Description of your changes: GitHub CI periodic functional tests proposed in https://github.com/kubeflow/pipelines/pull/10751 currently fail due to insufficient permissions: image image This PR modifies test file to be compatible with GitHub actions.

Checklist:

tmvfb avatar May 10 '24 12:05 tmvfb

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign connor-mccarthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 10 '24 12:05 google-oss-prow[bot]

Hi @tmvfb. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow[bot] avatar May 10 '24 12:05 google-oss-prow[bot]

/ok-to-test

hbelmiro avatar May 10 '24 12:05 hbelmiro

@tmvfb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test 5e688450d8956e3f03f2275920a43915b1b89395 link false /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar May 10 '24 13:05 google-oss-prow[bot]

@chensun could you please review and approve? Thanks.

DharmitD avatar May 20 '24 21:05 DharmitD

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 21 '24 20:05 google-oss-prow[bot]

@tmvfb this still seems to be failing: https://github.com/kubeflow/pipelines/actions/runs/9197318968 I tried to fix this on my fork but haven't had success so far: https://github.com/DharmitD/data-science-pipelines-argo/actions/runs/9197236926 Could you look into it and fix this perms issue? Please make sure to test the workflow on your fork first and then propose a PR with the changes, thanks.

DharmitD avatar May 22 '24 19:05 DharmitD

@tmvfb this still seems to be failing: https://github.com/kubeflow/pipelines/actions/runs/9197318968 I tried to fix this on my fork but haven't had success so far: https://github.com/DharmitD/data-science-pipelines-argo/actions/runs/9197236926 Could you look into it and fix this perms issue? Please make sure to test the workflow on your fork first and then propose a PR with the changes, thanks.

Yep, you are right, I already started looking into it, think I solved this particular issue here https://github.com/kubeflow/pipelines/pull/10837. Other problems are still very probable, but unfortunately I don't have a functional gcloud cluster to test on my fork/locally, so it seems it's going to be one step at a time.

tmvfb avatar May 22 '24 23:05 tmvfb