pipelines
pipelines copied to clipboard
feat(backend): Remove PipelineSpec Template storage from ObjStore responsibilies. Fixes #10509
Description of your changes: Fixes #10509
The PipelineSpec definition is currently stored in two places, DB and ObjStore, creating the potential for a competing source-of-truth problem. The ObjStore copy doesn't appear to actually be used/retrieved anywhere, so remove it from the list of responsibilities
Checklist:
- [x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/test kubeflow-pipeline-backend-test
@gmfrasca: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| kubeflow-pipeline-upgrade-test | 84ebbf74a98bcb6cf4d2bbb984f819712caf7cd1 | link | false | /test kubeflow-pipeline-upgrade-test |
| kubeflow-pipeline-e2e-test | 84ebbf74a98bcb6cf4d2bbb984f819712caf7cd1 | link | false | /test kubeflow-pipeline-e2e-test |
| kubeflow-pipeline-backend-test | 84ebbf74a98bcb6cf4d2bbb984f819712caf7cd1 | link | true | /test kubeflow-pipeline-backend-test |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@gmfrasca: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| kubeflow-pipeline-e2e-test | 84ebbf74a98bcb6cf4d2bbb984f819712caf7cd1 | link | false | /test kubeflow-pipeline-e2e-test |
| kubeflow-pipeline-backend-test | 84ebbf74a98bcb6cf4d2bbb984f819712caf7cd1 | link | true | /test kubeflow-pipeline-backend-test |
| kubeflow-pipeline-upgrade-test | 32c546207c37fb0a18053205a31480695628f7eb | link | false | /test kubeflow-pipeline-upgrade-test |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
what's the status of this? Just need reviews?
what's the status of this? Just need reviews?
yes, believe so
Confirmed this with pre-existing pipelines, they continue to be fetched successfully. New pipelines as well, and they are not stored in the object store. Great work!
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: HumairAK
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~backend/OWNERS~~ [HumairAK]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@gmfrasca this now has decoupled api server from the object store, can we update the docs here:
https://github.com/kubeflow/website/blob/master/content/en/docs/components/pipelines/operator-guides/configure-object-store.md
I think we can basically remove the entire first section
fyi @chensun