pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

[WIP] chore(test): remove pinning cluster version

Open chensun opened this issue 10 months ago • 3 comments

Description of your changes:

Checklist:

chensun avatar Apr 24 '24 18:04 chensun

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from chensun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Apr 24 '24 18:04 google-oss-prow[bot]

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test afff11b9892fae8786a9370e54b9da7e1e46718d link true /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar Apr 24 '24 19:04 google-oss-prow[bot]

Part of https://github.com/kubeflow/pipelines/issues/10779

chensun avatar May 03 '24 17:05 chensun

Hey @chensun - looking at the CI logs here, it appears the GKE cluster was successfully created and the failure is coming from the integration workflow test itself. I'm not terribly familiar with the GKE platform but IMO that means this PR is working as expected, and the CI failure is unrelated. Since the issue this PR fixes is blocking/causing problems with CI on other PRs, perhaps we can retest to see if it's an intermittent problem?

gmfrasca avatar May 17 '24 16:05 gmfrasca

/retest

gmfrasca avatar May 21 '24 16:05 gmfrasca

Hey @chensun - looking at the CI logs here, it appears the GKE cluster was successfully created and the failure is coming from the integration workflow test itself. I'm not terribly familiar with the GKE platform but IMO that means this PR is working as expected, and the CI failure is unrelated. Since the issue this PR fixes is blocking/causing problems with CI on other PRs, perhaps we can retest to see if it's an intermittent problem?

After the cluster was created, the test would time out in ~1 hr due to the Argo docker-in-docker issue that's mentioned in the comment, the fix needs to be migrating away from using Argo DinD to build test images.

I've made kubeflow-pipeline-e2e-test optional in https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2266, it should not block other PRs.

chensun avatar May 21 '24 16:05 chensun

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test ab97b62c3c6d12a6b2c66a4ec0cc01dd9405b972 link false /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar May 29 '24 03:05 google-oss-prow[bot]