pipelines
pipelines copied to clipboard
feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ConfigMaps as volumes and as env variables
Description of your changes: Part of https://github.com/kubeflow/pipelines/issues/9768 Fixes https://github.com/kubeflow/pipelines/issues/10251
Update kfp backend and kubernetes sdk to support Config Maps as volumes and environment variables.
Checklist:
- [x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
Hi @roytman. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/lint
/ok-to-test
Thanks @roytman, the tests are passed now. Are you planning to refactor the two for loops for configmap mount and configmap env into functions?
Hi @Tomcli , sorry, I don't see how it can be done without changes in kubernetes_platform/proto/kubernetes_executor_config.proto
and in k8s.io/api/core/v1
can we check it together?
Thanks @roytman, the tests are passed now. Are you planning to refactor the two for loops for configmap mount and configmap env into functions?
Hi @Tomcli , sorry, I don't see how it can be done without changes in
kubernetes_platform/proto/kubernetes_executor_config.proto
and ink8s.io/api/core/v1
can we check it together?
I'm thinking more of refactoring the common pieces between configmap and secret volume mount into a common function. Since it involved some object abstraction for configmapRef/secretRef, we can defer this to a follow up PR.
/lgtm
/lgtm for SDK
/lgtm for SDK
@roytman: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
kubeflow-pipelines-samples-v2 | 36daba6dfaf7baa2b4d2e6d2f97b0e1c95e97a85 | link | false | /test kubeflow-pipelines-samples-v2 |
kfp-kubernetes-execution-tests | 36daba6dfaf7baa2b4d2e6d2f97b0e1c95e97a85 | link | false | /test kfp-kubernetes-execution-tests |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chensun, connor-mccarthy, Tomcli
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [chensun]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment