pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ConfigMaps as volumes and as env variables

Open roytman opened this issue 1 year ago • 9 comments

Description of your changes: Part of https://github.com/kubeflow/pipelines/issues/9768 Fixes https://github.com/kubeflow/pipelines/issues/10251

Update kfp backend and kubernetes sdk to support Config Maps as volumes and environment variables.

Checklist:

roytman avatar Feb 14 '24 12:02 roytman

Hi @roytman. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Feb 14 '24 12:02 google-oss-prow[bot]

/lint

roytman avatar Feb 14 '24 12:02 roytman

/ok-to-test

Tomcli avatar Feb 14 '24 16:02 Tomcli

Thanks @roytman, the tests are passed now. Are you planning to refactor the two for loops for configmap mount and configmap env into functions?

Hi @Tomcli , sorry, I don't see how it can be done without changes in kubernetes_platform/proto/kubernetes_executor_config.proto and in k8s.io/api/core/v1 can we check it together?

roytman avatar Feb 15 '24 08:02 roytman

Thanks @roytman, the tests are passed now. Are you planning to refactor the two for loops for configmap mount and configmap env into functions?

Hi @Tomcli , sorry, I don't see how it can be done without changes in kubernetes_platform/proto/kubernetes_executor_config.proto and in k8s.io/api/core/v1 can we check it together?

I'm thinking more of refactoring the common pieces between configmap and secret volume mount into a common function. Since it involved some object abstraction for configmapRef/secretRef, we can defer this to a follow up PR.

/lgtm

Tomcli avatar Feb 15 '24 17:02 Tomcli

/lgtm for SDK

connor-mccarthy avatar Feb 16 '24 21:02 connor-mccarthy

/lgtm for SDK

connor-mccarthy avatar Feb 20 '24 23:02 connor-mccarthy

@roytman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 36daba6dfaf7baa2b4d2e6d2f97b0e1c95e97a85 link false /test kubeflow-pipelines-samples-v2
kfp-kubernetes-execution-tests 36daba6dfaf7baa2b4d2e6d2f97b0e1c95e97a85 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar Feb 23 '24 21:02 google-oss-prow[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, connor-mccarthy, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Feb 24 '24 05:02 google-oss-prow[bot]