pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

[sdk] Update requests-toolbelt dependencies

Open alanhdu opened this issue 1 year ago • 11 comments

Currently, kfp pins requests-toolbelt < 1. Would it be possible to support requests-toolbelt=1.0? From the release notes, I doubt any of the breaking changes affect kfp.

w/o this, it becomes impossible to use kfp with other dependencies that require reuqests-toolbelt 1.0.

alanhdu avatar Feb 12 '24 17:02 alanhdu

cc @connor-mccarthy

rimolive avatar Mar 13 '24 15:03 rimolive

Please feel free to open a PR and validate through our presubmit test first.

Edit: @connor-mccarthy mentioned there might be an issue caused by some transitive dependency, but feel free to use a PR to revalidate it.

chensun avatar Mar 14 '24 00:03 chensun

This is affecting repositories with poetry as the new poetry 1.8.* requires requests-toolbelt>=1 I created a pr here: https://github.com/kubeflow/pipelines/pull/10762 (disregard the failed attempts please :grimacing: )

SimonDR-Boltzmann avatar Apr 29 '24 12:04 SimonDR-Boltzmann

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 29 '24 07:06 github-actions[bot]

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Jul 20 '24 07:07 github-actions[bot]

/reopen

SimonDR-Boltzmann avatar Jul 22 '24 06:07 SimonDR-Boltzmann

@SimonDR-Boltzmann: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

google-oss-prow[bot] avatar Jul 22 '24 06:07 google-oss-prow[bot]

Can this issue be reopened please? It is still causing dependency problems for us.

SimonDR-Boltzmann avatar Aug 19 '24 09:08 SimonDR-Boltzmann

/reopen

gregsheremeta avatar Aug 19 '24 12:08 gregsheremeta

@gregsheremeta: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Aug 19 '24 12:08 google-oss-prow[bot]